Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESS][8.13] Indicator match rule alert suppression docs #4888

Merged
merged 14 commits into from
Mar 20, 2024

Conversation

@nastasha-solomon nastasha-solomon added Feature: Rules Team: Detection Engine Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Small Issues that can be resolved quickly v8.13.0 labels Mar 7, 2024
@nastasha-solomon nastasha-solomon self-assigned this Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@nastasha-solomon nastasha-solomon marked this pull request as ready for review March 7, 2024 22:46
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner March 7, 2024 22:46
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small edit suggestion. Looks good!

docs/detections/alert-suppression.asciidoc Outdated Show resolved Hide resolved
vitaliidm
vitaliidm previously approved these changes Mar 12, 2024
benironside
benironside previously approved these changes Mar 12, 2024
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one minor bug otherwise LGTM

docs/detections/alert-suppression.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
@nastasha-solomon nastasha-solomon dismissed stale reviews from benironside and vitaliidm via ffe3b63 March 12, 2024 19:44
@nastasha-solomon nastasha-solomon requested a review from a team March 18, 2024 13:44
@nastasha-solomon nastasha-solomon merged commit 5be1fc9 into main Mar 20, 2024
3 checks passed
@nastasha-solomon nastasha-solomon deleted the issue-4715-alert-supp-im branch March 20, 2024 18:53
mergify bot pushed a commit that referenced this pull request Mar 20, 2024
* First draft

* Title updates

* Moved info

* Update docs/detections/alert-suppression.asciidoc

* Update docs/detections/alert-suppression.asciidoc

* Update docs/detections/alert-suppression.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Vitalii's feedback

* Reformatting note

* Updated wording

* Update docs/detections/alert-suppression.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

---------

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 5be1fc9)
nastasha-solomon added a commit that referenced this pull request Mar 20, 2024
…ort #4888) (#4946)

* First draft

* Title updates

* Moved info

* Update docs/detections/alert-suppression.asciidoc

* Update docs/detections/alert-suppression.asciidoc

* Update docs/detections/alert-suppression.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Vitalii's feedback

* Reformatting note

* Updated wording

* Update docs/detections/alert-suppression.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

---------

Co-authored-by: Joe Peeples <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit 5be1fc9)

Co-authored-by: Nastasha Solomon <[email protected]>
@nastasha-solomon nastasha-solomon mentioned this pull request Mar 21, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Small Issues that can be resolved quickly Feature: Rules Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Detection Engine v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants